Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 )
Change subject: IMPALA-8444: Fix performance regression when building privilege name ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/13095/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13095/8//COMMIT_MSG@8 PS8, Line 8: > The commit message could also reflect that there are also some fixes relate Done http://gerrit.cloudera.org:8080/#/c/13095/8//COMMIT_MSG@33 PS8, Line 33: While fixing this, I found a bug where Principal : stores the PrincipalPrivilege in a case insensitive way. This is true : for all privilege scopes, except URI. This patch fixes the issue by : making privilege name to be case sensitiv > Is this still correct? Comment updated. Done. http://gerrit.cloudera.org:8080/#/c/13095/8/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java File fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java: http://gerrit.cloudera.org:8080/#/c/13095/8/fe/src/main/java/org/apache/impala/catalog/CatalogObjectCache.java@158 PS8, Line 158: } > Is there some kind of whitespace change here? I think this is a gerrit bug. I've seen this before. There should not be any change in this file. http://gerrit.cloudera.org:8080/#/c/13095/2/fe/src/main/java/org/apache/impala/catalog/Principal.java File fe/src/main/java/org/apache/impala/catalog/Principal.java: http://gerrit.cloudera.org:8080/#/c/13095/2/fe/src/main/java/org/apache/impala/catalog/Principal.java@63 PS2, Line 63: */ : public boolean addPrivilege(PrincipalPrivilege privilege) { : return principalPrivileges_.add(privilege); > Can you add tests for the bugs that were fixed? Done -- To view, visit http://gerrit.cloudera.org:8080/13095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942d9b55f07c8972f69e532567d9b7d80fceb6e5 Gerrit-Change-Number: 13095 Gerrit-PatchSet: 9 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 26 Apr 2019 15:52:54 +0000 Gerrit-HasComments: Yes
