Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13051 )
Change subject: IMPALA-7957: Fix slot equivalences may be enforced multiple times ...................................................................... Patch Set 3: (1 comment) > Patch Set 3: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/13051/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/13051/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1840 PS3, Line 1840: // Loop over all pairs of equivalent slots and merge their disjoint slots sets, > I did a proof-of-concept fix that solved the bug I found by checking if the Yes, that would fix the extra bug. I think a more elegant way is to union the slots in current tuple based on previous inferred conjuncts when we init the partialEquivSlots. Unfortunately, it doesn't work. I'm still confused about this and going to look deeper. Besides, my proof may need deeper review since I found several other places could infer predicates too, e.g. getHashLookupJoinConjuncts, createJoinNode. -- To view, visit http://gerrit.cloudera.org:8080/13051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida2d5d8149b217e18ebae61e136848162503653e Gerrit-Change-Number: 13051 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 13:55:37 +0000 Gerrit-HasComments: Yes
