Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 )
Change subject: IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/13074/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13074/8//COMMIT_MSG@13 PS8, Line 13: SHOW GRANT USER/GROUP <id> ON server; > Instead of <resource> can we list down what the valid resources? Done http://gerrit.cloudera.org:8080/#/c/13074/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13074/8/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@267 PS8, Line 267: } else if (privilege.getUri() != null) { : resources.add(RangerUtil.createUriResource(privilege)); : } else if (privilege.getDb_name() != null) { : // DB is used by column and function resources. : resources.add(RangerUtil.createColumnResource(privilege)); : resources.add(RangerUtil.createFunctionResource(privilege)); : } else { : // Server is used by column, function, and URI resources. : resources.add(RangerUtil.createColumnResource(privilege)); : resources.add(RangerUtil.createUriResource(privilege)); : resources.add(RangerUtil.createFunctionResource(privilege)); : } : : L > I feel like we shouldn't be calling functions from RangerCatalogdAuthorizat Done -- To view, visit http://gerrit.cloudera.org:8080/13074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic46fb9fc36c9e11ec78d5840d22eb0668150c2a4 Gerrit-Change-Number: 13074 Gerrit-PatchSet: 9 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 15:14:49 +0000 Gerrit-HasComments: Yes
