Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13122 )

Change subject: WIP ONLY - IMPALA-8121: part 1: use local catalog in containers
......................................................................


Patch Set 7:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/13122/7/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/13122/7/tests/common/impala_test_suite.py@895
PS7, Line 895: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/common/skip.py
File tests/common/skip.py:

http://gerrit.cloudera.org:8080/#/c/13122/7/tests/common/skip.py@200
PS7, Line 200: class SkipIfCatalogV2:
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_compute_stats.py
File tests/metadata/test_compute_stats.py:

http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_compute_stats.py@21
PS7, Line 21:  
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_compute_stats.py@21
PS7, Line 21: from tests.common.environ import IMPALA_TEST_CLUSTER_PROPERTIES
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_compute_stats.py@57
PS7, Line 57: a
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_compute_stats.py@59
PS7, Line 59: e
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_metadata_query_statements.py
File tests/metadata/test_metadata_query_statements.py:

http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_metadata_query_statements.py@22
PS7, Line 22: import time
flake8: F401 'time' imported but unused


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/metadata/test_metadata_query_statements.py@159
PS7, Line 159:
flake8: E261 at least two spaces before inline comment


http://gerrit.cloudera.org:8080/#/c/13122/7/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/13122/7/tests/webserver/test_web_pages.py@18
PS7, Line 18: from tests.common.environ import (IMPALA_TEST_CLUSTER_PROPERTIES,
flake8: F811 redefinition of unused 'IMPALA_TEST_CLUSTER_PROPERTIES' from line 
18



--
To view, visit http://gerrit.cloudera.org:8080/13122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060f2076da74fbbe92ae26dbad51f09a3bd20169
Gerrit-Change-Number: 13122
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 30 Apr 2019 20:48:21 +0000
Gerrit-HasComments: Yes

Reply via email to