Joe McDonnell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13204


Change subject: IMPALA-8475: Fix unbound CMAKE_BUILD_TYPE_LIST in buildall.sh
......................................................................

IMPALA-8475: Fix unbound CMAKE_BUILD_TYPE_LIST in buildall.sh

A recent change introduced a shell array CMAKE_BUILD_TYPE_LIST.
For debug builds, it is empty, because no build types are passed
into buildall.sh. This is a problem on Centos, because the
condition [[ -v CMAKE_BUILD_TYPE_LIST ]] is true for an empty
array on Centos. This causes us to execute code meant for
non-empty arrays and trigger an unbound variable error.

This changes the condition to [[ -n "${CMAKE_BUILD_TYPE_LIST:+1}" ]],
which returns true only if the array is not empty.

Testing:
 - Ran buildall.sh on Centos 7 and Ubuntu 16.04.

Change-Id: Ifd3b1af05af780d1a91cc781afff84b56f5aeb59
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/13204/1
--
To view, visit http://gerrit.cloudera.org:8080/13204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd3b1af05af780d1a91cc781afff84b56f5aeb59
Gerrit-Change-Number: 13204
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>

Reply via email to