Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 )
Change subject: IMPALA-8269: Refactor authorization test package structure ...................................................................... Patch Set 1: Code-Review+1 (1 comment) This makes sense to me. I'm willing to bump to +2 if no one else has any comments. http://gerrit.cloudera.org:8080/#/c/13208/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/13208/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@38 PS1, Line 38: import org.apache.impala.authorization.AuthorizationConfig; : import org.apache.impala.authorization.AuthorizationFactory; : import org.apache.impala.authorization.AuthorizationProvider; : import org.apache.impala.authorization.PrivilegeRequest; : import org.apache.impala.authorization.User; : import org.apache.impala.authorization.AuthorizationException; Nit: Now that this is in the authorization package, should we remove these? -- To view, visit http://gerrit.cloudera.org:8080/13208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I525ff71f63d7c306d82b4c111f98ff327e4a07b3 Gerrit-Change-Number: 13208 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 01 May 2019 22:34:04 +0000 Gerrit-HasComments: Yes
