Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12987 )
Change subject: IMPALA-8341: Data cache for remote reads ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/12987/7/be/src/runtime/io/data-cache-test.cc File be/src/runtime/io/data-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/12987/7/be/src/runtime/io/data-cache-test.cc@274 PS7, Line 274: ScopedFlagSetter<int64_t>::Make(&FLAGS_data_cache_file_max_size_bytes, 1024 * 1024); I think gflags has a built in 'google::FlagsSaver', no? It handles restoring all modified flags upon scope exit. Soi you could just do: google::FlagSaver s; FLAGS_data_cache_file_max_size_bytes = 1024 * 1024; (in kudu we do the FlagSaver thing in our base test class, not sure if there is something equivalent in Impala) http://gerrit.cloudera.org:8080/#/c/12987/7/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/12987/7/be/src/runtime/io/data-cache.cc@245 PS7, Line 245: CacheFile(std::string path) : path_(move(path)) { } nit: explicit http://gerrit.cloudera.org:8080/#/c/12987/7/be/src/runtime/io/data-cache.cc@301 PS7, Line 301: DCHECK(partition_lock.owns_lock()); here I think you could just call lock_.DCheckLocked() right? http://gerrit.cloudera.org:8080/#/c/12987/7/be/src/runtime/io/data-cache.cc@409 PS7, Line 409: UnpackCacheEntry(meta_cache_->Value(handle), &entry); why not have UnpackCacheEntry return the CacheEntry object? (the generated code would be equivalent due to return value optimization) Or make a constructor for CacheEntry which takes a Slice directly? -- To view, visit http://gerrit.cloudera.org:8080/12987 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I734803c1c1787c858dc3ffa0a2c0e33e77b12edc Gerrit-Change-Number: 12987 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 May 2019 22:47:18 +0000 Gerrit-HasComments: Yes
