Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 )
Change subject: IMPALA-7031: Add additional info to query canceled from http endpoint ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12926/6/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/12926/6/be/src/service/impala-hs2-server.cc@179 PS6, Line 179: if (ImpalaServer::isUnregistered(query_id)) { : err_msg = Substitute("Query is already unregistered: $0", PrintId(query_id)); : } else { : err_msg = Substitute("Invalid query handle: $0", PrintId(query_id)); : } this looks like common code that you can refactor out and use at all other places -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 6 Gerrit-Owner: Alice Fan <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 02 May 2019 20:07:51 +0000 Gerrit-HasComments: Yes
