Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13193 )
Change subject: IMPALA-7293: Show tuple layout in explain plan. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13193/3/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/13193/3/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@76 PS3, Line 76: public static final OffsetComparator OffsetComparator_ = new OffsetComparator(); you can probably do: public static final Comparator<SlotDescriptor> COMPARE_BY_OFFSET = Ordering.natural().onResultOf(SlotDescriptor::getByteOffset); (using guava's Ordering utility) http://gerrit.cloudera.org:8080/#/c/13193/3/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@331 PS3, Line 331: expBuilder.append("Slot " + getId() + " "); Consider using Objects.toStringHelper, eg: return Objects.toStringHelper("Slot") .add("offset", getByteOffset()) .add(type, getType() .toString(); which results in a string like 'Slot{offset=1, type=INT}', etc. and it has handy methods to skip null, etc. -- To view, visit http://gerrit.cloudera.org:8080/13193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac38290217a219e75400e4206835992a7ea31dba Gerrit-Change-Number: 13193 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 05:49:21 +0000 Gerrit-HasComments: Yes
