Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13189 )
Change subject: IMPALA-7370: DATE: Read/Write to parquet. ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/13189/3/be/src/exec/parquet/parquet-column-stats.inline.h File be/src/exec/parquet/parquet-column-stats.inline.h: http://gerrit.cloudera.org:8080/#/c/13189/3/be/src/exec/parquet/parquet-column-stats.inline.h@144 PS3, Line 144: template <typename T> : template <parquet::Type::type ParquetType> : inline bool ColumnStats<T>: nit: If T would be not be a class template, then this function also wouldn't need to be a class function. http://gerrit.cloudera.org:8080/#/c/13189/3/be/src/exec/parquet/parquet-column-stats.inline.h@178 PS3, Line 178: const DateValue* result = reinterpret_cast<DateValue*>(slot); nit: This could be moved to the start of the function, and DecodePlainValueNoValidation() could expect T* instead of void* in the slot. This would make the solution with the template 1-2 line shorter than the original. :) http://gerrit.cloudera.org:8080/#/c/13189/3/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java File fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java: http://gerrit.cloudera.org:8080/#/c/13189/3/fe/src/main/java/org/apache/impala/analysis/ParquetHelper.java@282 PS3, Line 282: if (prim.getPrimitiveTypeName() == PrimitiveType.PrimitiveTypeName.INT32 && I guess this was needed to make CREATE TABLE LIKE PARQUET work with dates - can you mention this in the commit message? I consider this to be a somewhat separate feature from the reading/writing of data. -- To view, visit http://gerrit.cloudera.org:8080/13189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67da03754531660bc8de3b6935580d46deae1814 Gerrit-Change-Number: 13189 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 03 May 2019 15:37:44 +0000 Gerrit-HasComments: Yes
