Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13249 )
Change subject: Fix issues with toolchain Python and bump version ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13249/1/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/13249/1/buildall.sh@57 PS1, Line 57: PYTHON_VERSION=2.7.16 $SOURCE_DIR/source/python/build.sh do you know what the history of darwin also building a "fake package" for 2.7.11? http://gerrit.cloudera.org:8080/#/c/13249/1/buildall.sh@59 PS1, Line 59: PYTHON_VERSION=2.7.16 build_fake_package "python" I suppose we don't care about the BUILD_HISTORICAL option to keep building the old versions? http://gerrit.cloudera.org:8080/#/c/13249/1/source/python/build.sh File source/python/build.sh: http://gerrit.cloudera.org:8080/#/c/13249/1/source/python/build.sh@37 PS1, Line 37: # a different directory from the one used during our toolchain build. do we have any issues if native-toolchain gets built with ccache or distcc? Or is this GCC always the gcc that was built earlier in the toolchain build? Maybe we should explicitly check that CC == "gcc" so we have confidence it will produce a working package? -- To view, visit http://gerrit.cloudera.org:8080/13249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e6c9c4371d3d6c1193c2cc02d45c22b04137672 Gerrit-Change-Number: 13249 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 07 May 2019 16:45:06 +0000 Gerrit-HasComments: Yes
