Hector Acosta has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13232 )

Change subject: Create CCACHE_DIR if not present
......................................................................


Patch Set 1:

> LGTM, I should have caught it the first time around though...
 > Apparently download_ccache is called before init-compiler.sh has a
 > chance to create the CCACHE dir.
 > Letting Hector take a look as well

FWIW, this works fine in the docker path 
(https://github.com/cloudera/native-toolchain/blob/master/in-docker.py#L112), 
which is why the jenkins job works fine.


--
To view, visit http://gerrit.cloudera.org:8080/13232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bbc7753ce31df94e68a4aff20940deec9b66d64
Gerrit-Change-Number: 13232
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 May 2019 19:15:38 +0000
Gerrit-HasComments: No

Reply via email to