Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 )
Change subject: IMPALA-5843: Use page index in Parquet files to skip pages ...................................................................... Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/12065/19/be/src/exec/parquet/parquet-column-stats.h File be/src/exec/parquet/parquet-column-stats.h: http://gerrit.cloudera.org:8080/#/c/12065/19/be/src/exec/parquet/parquet-column-stats.h@278 PS19, Line 278: /// Returns the required stats field for the given function. 'fn_name' can be 'le', : /// 'lt', 'ge', and 'gt' (i.e. binary operators <=, <, >=, >). If we want to check that : /// whether a column contains a value less than a constant, we need the minimum value of : /// the column to answer that question. And, to answer the opposite question we need the : /// maximum value. The required stats field (min/max) will be stored in 'stats_field'. : /// The function returns true on success, false otherwise. : static bool GetRequiredStatsField(const std::string& fn_name, StatsField* stats_field); > optional: I think that this long comment makes this simple function look co I followed the rule of "put multi-line definitions to the .cc file". Yeah, the implementation is quite simple, but I thought it's worth to explain how and why it chooses a stats field. -- To view, visit http://gerrit.cloudera.org:8080/12065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cc99f129f2048dbafbe7f5a51d1ea3a5005731a Gerrit-Change-Number: 12065 Gerrit-PatchSet: 19 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 08 May 2019 10:48:33 +0000 Gerrit-HasComments: Yes
