Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13275 )

Change subject: IMPALA-2029. Implement our own getJNIEnv equivalent
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

This seems to make sense to me.

http://gerrit.cloudera.org:8080/#/c/13275/1/be/src/util/jni-util.h
File be/src/util/jni-util.h:

http://gerrit.cloudera.org:8080/#/c/13275/1/be/src/util/jni-util.h@395
PS1, Line 395: tls_env
nit: _ on end to be consistent.



--
To view, visit http://gerrit.cloudera.org:8080/13275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I766bcfd70addb00e9fd8a860e89c2a1c5d4c71d5
Gerrit-Change-Number: 13275
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Wed, 08 May 2019 20:27:42 +0000
Gerrit-HasComments: Yes

Reply via email to