Hello Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13286
to review the following change.
Change subject: Update cmake to 3.14.3
......................................................................
Update cmake to 3.14.3
This updates to the latest cmake, which includes a few improvements that
may be helpful. In particular, the Ninja generator avoids generating
some false dependencies[1]
Instead of carrying over the patch to change one of the #defines in the
CMake source, this uses a newly-provided variable when building CMake
to accomplish the same.
I tested building Impala with this version of CMake on el7 and it worked
fine.
[1] https://gitlab.kitware.com/cmake/cmake/merge_requests/430
Change-Id: I1ad46a7b820bbb727ce47219f03f1d4a36301ab4
---
M init.sh
M source/cmake/build.sh
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain
refs/changes/86/13286/1
--
To view, visit http://gerrit.cloudera.org:8080/13286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ad46a7b820bbb727ce47219f03f1d4a36301ab4
Gerrit-Change-Number: 13286
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
