Hello Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13289
to review the following change.
Change subject: expr-test: use gtest parameterization
......................................................................
expr-test: use gtest parameterization
Instead of running the tests three times with different flags from
main(), this uses gtest's parameterization feature to accomplish the
same.
The advantage here is that we end up with different test names for each
of the runs. Additionally, this moves the setup code into a proper setup
method so that executing expr-test --gtest_list_tests doesn't waste time
starting a cluster.
This is prep work towards adding multi-threaded test execution for
long-running tests. expr-test seems to currently be one of the worst
offenders.
Change-Id: Idc9fb24ad62b4aa2e120a99d74ae04bb221c034b
---
M be/src/exprs/expr-test.cc
1 file changed, 126 insertions(+), 125 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/13289/1
--
To view, visit http://gerrit.cloudera.org:8080/13289
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc9fb24ad62b4aa2e120a99d74ae04bb221c034b
Gerrit-Change-Number: 13289
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
