Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13226 )
Change subject: IMPALA-8121: part 2: use local catalog in containers ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/13226/10/fe/src/test/java/org/apache/impala/service/JdbcTest.java File fe/src/test/java/org/apache/impala/service/JdbcTest.java: http://gerrit.cloudera.org:8080/#/c/13226/10/fe/src/test/java/org/apache/impala/service/JdbcTest.java@487 PS10, Line 487: assertTrue("Incorrect table comment: " + remarks, > I don't suppose there's any way to condition this on the configuration of t I decided not to try building out infrastructure for Java tests to detect the flags, since there are so few Java tests that interact with the e2e test cluster. Instead I added a python test that asserts this in test_hs2.py. http://gerrit.cloudera.org:8080/#/c/13226/10/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13226/10/tests/common/impala_test_suite.py@938 PS10, Line 938: 1 > {2} here right? Done -- To view, visit http://gerrit.cloudera.org:8080/13226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I900d4b718cca98bcf86d36a2e64c0b6a424a5b7c Gerrit-Change-Number: 13226 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Internal Jenkins (8) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2019 23:40:36 +0000 Gerrit-HasComments: Yes
