Alice Fan has posted comments on this change. ( http://gerrit.cloudera.org:8080/12926 )
Change subject: IMPALA-7031: Add additional info to query canceled from http endpoint ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/12926/10/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/12926/10/tests/hs2/test_hs2.py@336 PS10, Line 336: assert err_msg in get_operation_status_resp.status.errorMessage > wont this fail if the error message is "Invalid query handle. The query is Thanks for catching this. This will not be put into archive log http://gerrit.cloudera.org:8080/#/c/12926/10/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12926/10/tests/webserver/test_web_pages.py@549 PS10, Line 549: """Verify that an indicative error message is returned when trying to use a query > nit: Verify that Done http://gerrit.cloudera.org:8080/#/c/12926/10/tests/webserver/test_web_pages.py@551 PS10, Line 551: is still in the query archive log, so to make sure it is not pushed out of the log by > nit: out of the log Thanks. -- To view, visit http://gerrit.cloudera.org:8080/12926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56983d40e0542bc734ec5a66c339b5131b7b56c8 Gerrit-Change-Number: 12926 Gerrit-PatchSet: 11 Gerrit-Owner: Alice Fan <[email protected]> Gerrit-Reviewer: Alice Fan <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2019 00:25:52 +0000 Gerrit-HasComments: Yes
