Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13283 )
Change subject: IMPALA-8369: Fixing some core tests in Hive environment ...................................................................... Patch Set 3: (2 comments) It turned out that the changed file number in tpch_nested_parquet.customer broke several planner tests, so it would be much better to find a way to generate the same number of files both on Hive 2+3 instead of creating individual hacks for the different tests. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/impala_test_suite.py@738 PS3, Line 738: get_partition_names > is this a change of behavior in hive client in version 3? If yes, is it bre It looks like that it doesn't, -1 works both in Hive 2 and 3. http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/13283/3/tests/common/skip.py@216 PS3, Line 216: == > should this be >= 3 For me "IfHive3" means that it should be exactly 3. If there will be a lot of tests which should be skipped with both Hive 3 and 4, then a new SkipIf for >= 3 will make sense. I do not know of plans to work with Hive 4 - I hope that once this comes up, the support for Hive2 will be already dropped. -- To view, visit http://gerrit.cloudera.org:8080/13283 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45d9b9312c6c77f436ab020ae68c15f3c7c737de Gerrit-Change-Number: 13283 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2019 16:34:03 +0000 Gerrit-HasComments: Yes
