Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13284 )
Change subject: IMPALA-8281: Misc Sentry decoupling clean up ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/13284/9/fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13284/9/fe/src/main/java/org/apache/impala/authorization/sentry/SentryCatalogdAuthorizationManager.java@118 PS9, Line 118: Role role = sentryProxy_.dropRole(requestingUser, params.getRole_name()); : if (role == null) { : throw new AuthorizationException(String.format("Role '%s' does not exist.", : params.getRole_name())); : } This code isn't the same. In this code we always ask Sentry to drop whereas previously we checked if the role was in the catalog first. -- To view, visit http://gerrit.cloudera.org:8080/13284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id24a00dd395e30e4c392f085893e9561da2ee539 Gerrit-Change-Number: 13284 Gerrit-PatchSet: 9 Gerrit-Owner: Austin Nobis <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 10 May 2019 17:01:31 +0000 Gerrit-HasComments: Yes
