Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13253 )
Change subject: [IMPALA-8435] Prohibit operations on full transactional table. ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13253/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13253/2//COMMIT_MSG@7 PS2, Line 7: [IMPALA-8435] > Impala commits use the following format most of the time: ping :) http://gerrit.cloudera.org:8080/#/c/13253/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/13253/3/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@167 PS3, Line 167: > I am having trouble finding out how to reply better to a comment here. But I am ok with the current solution. Maybe we will find a nice way to abstract requirements about a table in the future. http://gerrit.cloudera.org:8080/#/c/13253/2/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java: http://gerrit.cloudera.org:8080/#/c/13253/2/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@563 PS2, Line 563: AnalyzesOk("select * from functional.insert_only_transactional_table"); : > Done The old duplicate statement are still here. -- To view, visit http://gerrit.cloudera.org:8080/13253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I542570e30afdd8351250236d1be0077a170dd4ab Gerrit-Change-Number: 13253 Gerrit-PatchSet: 3 Gerrit-Owner: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Sat, 11 May 2019 15:38:57 +0000 Gerrit-HasComments: Yes
