Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13293 )
Change subject: IMPALA-8497: Fixed ArrayIndexOutOfBoundsException when sql ends with line break ...................................................................... Patch Set 1: (3 comments) Hi Sheng, I leave some minor suggestions. Welcome for your contribution! http://gerrit.cloudera.org:8080/#/c/13293/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13293/1//COMMIT_MSG@9 PS1, Line 9: When sql ends with '\n', impala would throw ArrayIndexOutOfBoundsException, instead of Syntax error. nit: could you refactor the commit message following the guideline? - First line (title) is 50 characters or less. - Remaining text should be wrapped at 72 characters. (No more than 72 characters in each line) http://gerrit.cloudera.org:8080/#/c/13293/1/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/13293/1/fe/src/main/cup/sql-parser.cup@181 PS1, Line 181: // This is for IMPALA-8497, when sql ends with '\n' nit: we follow the commit format: // IMPALA-8497: dealing with query ends with '\n' http://gerrit.cloudera.org:8080/#/c/13293/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/13293/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3988 PS1, Line 3988: ParserError("\n"); Could you also add some tests in TestGetErrorMsg? -- To view, visit http://gerrit.cloudera.org:8080/13293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f034b351d0468a77773f6482e27ddef818b34d8 Gerrit-Change-Number: 13293 Gerrit-PatchSet: 1 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 06:20:41 +0000 Gerrit-HasComments: Yes
