Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13318 )
Change subject: IMPALA-8504: Support CREATE TABLE statement with Kudu/HMS integration ...................................................................... Patch Set 1: (41 comments) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@255 PS1, Line 255: private void analyzeKuduTableProperties(Analyzer analyzer, boolean isHMSIntegrationEnabled) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@270 PS1, Line 270: // TODO(hao): remove ALL privileges on SERVER validation when HMS Integration is enabled. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@285 PS1, Line 285: (!isHMSIntegrationEnabled && !handler.equals(KuduTable.KUDU_LEGACY_STORAGE_HANDLER)))) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@304 PS1, Line 304: String.format("Table property %s should not be specified when creating an Kudu table.", line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@309 PS1, Line 309: * Populates Kudu master addresses either from table property or the -kudu_master_hosts flag. line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@322 PS1, Line 322: private void analyzeExternalKuduTableParams(Analyzer analyzer, boolean isHMSIntegrationEnabled) line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@353 PS1, Line 353: private void analyzeManagedKuduTableParams(Analyzer analyzer, boolean isHMSIntegrationEnabled) line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@177 PS1, Line 177: public static boolean isHMSIntegrationEnabled(String kuduMasters) throws ImpalaRuntimeException { line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@242 PS1, Line 242: throw new TableLoadingException("Unable to get Kudu HMS integration configuration " + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java: http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java@208 PS1, Line 208: throw new LocalCatalogException("Unable to get Kudu HMS integration configuration " + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@182 PS1, Line 182: AnalyzesOk(String.format("create table tab (x int primary key) partition by hash (x) " + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@190 PS1, Line 190: AnalyzesOk(String.format("create table tdata_no_port (id int primary key, name string, " + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@201 PS1, Line 201: AnalyzesOk(String.format("create table tab (x int primary key) stored as kudu tblproperties (" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@423 PS1, Line 423: String.format("Table property %s should not be specified when creating an Kudu table.", line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@437 PS1, Line 437: AnalysisError("create external table t stored as kudu tblproperties('kudu.table_name'='t')", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@438 PS1, Line 438: String.format("Table property %s should not be specified when creating an external " + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@452 PS1, Line 452: "%s 'kudu.master_addresses' = '%s')", tableName.isEmpty() ? tableName : tableName + ",", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@465 PS1, Line 465: AnalysisError(String.format("create external table t (x int primary key) stored as kudu %s", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@474 PS1, Line 474: "%s 'storage_handler'='foo')", tableName.isEmpty() ? tableName : tableName + ","), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@483 PS1, Line 483: AnalysisError(String.format("create external table t stored as kudu cached in 'testPool' %s", line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@487 PS1, Line 487: AnalysisError(String.format("create external table t stored as kudu location '/warehouse' " + line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@492 PS1, Line 492: "%s 'kudu.table_id'='123456')", tableName.isEmpty() ? tableName : tableName + ","), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@493 PS1, Line 493: String.format("Table property %s should not be specified when creating an Kudu table.", line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java File fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java: http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@24 PS1, Line 24: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "SELECT"))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@31 PS1, Line 31: new TAccessEvent("functional_kudu.alltypes", TCatalogObjectType.TABLE, "SELECT"), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@32 PS1, Line 32: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "INSERT"))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@39 PS1, Line 39: new TAccessEvent("functional_kudu.alltypes", TCatalogObjectType.TABLE, "SELECT"), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@40 PS1, Line 40: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "ALL"))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@46 PS1, Line 46: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "SELECT"), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@47 PS1, Line 47: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "ALL"))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@54 PS1, Line 54: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "SELECT"), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@55 PS1, Line 55: new TAccessEvent("functional_kudu.alltypes", TCatalogObjectType.TABLE, "SELECT"), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@56 PS1, Line 56: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "ALL"))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@62 PS1, Line 62: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "SELECT"), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@63 PS1, Line 63: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "ALL"))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@78 PS1, Line 78: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "ALTER"), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/AuditingKuduTest.java@79 PS1, Line 79: new TAccessEvent("functional_kudu.testtbl", TCatalogObjectType.TABLE, "SELECT"))); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@337 PS1, Line 337: testToSql(String.format("create table p (a bigint primary key, b timestamp default '1987-05-19') " + line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@371 PS1, Line 371: testToSql(String.format("create table p primary key (a,b) partition by hash(a) partitions 3, " + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@376 PS1, Line 376: String.format("CREATE TABLE default.p PRIMARY KEY (a, b) PARTITION BY HASH (a) PARTITIONS 3, " + line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/13318/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@379 PS1, Line 379: "SELECT int_col a, bigint_col b FROM functional.alltypes", kuduMasters, storageHandler), true); line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I465673d749221bd5f3772814b1c22c2673a53f5c Gerrit-Change-Number: 13318 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 06:29:34 +0000 Gerrit-HasComments: Yes
