Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13295 )
Change subject: IMPALA-8530: Return more user friendly error messages on unsupported SQL ...................................................................... Patch Set 3: Code-Review+2 (1 comment) small nit http://gerrit.cloudera.org:8080/#/c/13295/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/13295/3/fe/src/main/java/org/apache/impala/authorization/sentry/SentryImpaladAuthorizationManager.java@228 PS3, Line 228: default: worth putting this in an explicit 'case GROUP' in case we add another enum value later? Or use params.getPrincipal_type().toString() instead of 'GROUP' -- To view, visit http://gerrit.cloudera.org:8080/13295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf08ee9e1a83d7597811b1c8585aee5872d0baaf Gerrit-Change-Number: 13295 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Austin Nobis <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 17:11:16 +0000 Gerrit-HasComments: Yes
