Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13252 )
Change subject: IMPALA-8509. Lazily evaluate LOAD sections during data load ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13252/3/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/13252/3/testdata/bin/generate-schema-statements.py@589 PS3, Line 589: insert = section['DEPENDENT_LOAD'] : insert_hive = section['DEPENDENT_LOAD_HIVE'] > Nit: can you use different variable names for the unevaluated vs evaluated Ended up moving the evaluation to even lazier so that no variable name was needed at all. -- To view, visit http://gerrit.cloudera.org:8080/13252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc64bb5cac4fda675607672329c04c5caf810d99 Gerrit-Change-Number: 13252 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 13 May 2019 23:18:08 +0000 Gerrit-HasComments: Yes
