Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13329 )
Change subject: WIP: IMPALA-6433: Part 1: Extract page reading logic from ParquetColumnReader ...................................................................... Patch Set 2: (8 comments) Did a first pass, will take another round tomorrow. http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-column-readers.cc@1124 PS2, Line 1124: if (data_size == 0) { : return CreateDictionaryDecoder(nullptr, 0, &dict_decoder); : } nit: fits single-line http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-column-readers.cc@1178 PS2, Line 1178: if (eos) { : return HandleTooEarlyEos(); : } nit: single line http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.h File be/src/exec/parquet/parquet-page-reader.h: http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.h@39 PS2, Line 39: /// Moved to implementation to be able to forward declare class in scoped_ptr. nit: Please rephrase, I can't parse this sentence. http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.h@83 PS2, Line 83: & nit: output parameters usually have pointer types http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.h@91 PS2, Line 91: slot_desc has_slot_desc http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.cc File be/src/exec/parquet/parquet-page-reader.cc: http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.cc@60 PS2, Line 60: ParquetColumnReader ParquetPageReader http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.cc@382 PS2, Line 382: nit: indent http://gerrit.cloudera.org:8080/#/c/13329/2/be/src/exec/parquet/parquet-page-reader.cc@413 PS2, Line 413: nit: indent -- To view, visit http://gerrit.cloudera.org:8080/13329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0289394adcb97a3529313030930c9c5b85aaa12 Gerrit-Change-Number: 13329 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2019 17:00:02 +0000 Gerrit-HasComments: Yes
