Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13330 )
Change subject: Enable data cache by default for all S3 builds ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh@64 PS2, Line 64: /tmp Do we know if the choice of filesystem matters for the cache? For example, /tmp might be on tmpfs. Does it matter? http://gerrit.cloudera.org:8080/#/c/13330/2/bin/run-all-tests.sh@78 PS2, Line 78: ${TARGET_FILESYSTEM}" == "s3" I think the data caching is orthogonal to the filesystem, and we might want to test with the filesystem as HDFS (e.g. on containers). So, maybe have an DATA_CACHE_ENABLED flag that when true enables the cache. Then, the customizable things would the directory and size. For automated tests, this can be passed in as part of the test configuration. -- To view, visit http://gerrit.cloudera.org:8080/13330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09117ab289c2355408212a5fc6493ab751f4853b Gerrit-Change-Number: 13330 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Comment-Date: Wed, 15 May 2019 23:34:56 +0000 Gerrit-HasComments: Yes
