Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13346 )

Change subject: IMPALA-8476: Replace Sentry admin check workaround with proper 
Sentry API
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13346/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java
File fe/src/main/java/org/apache/impala/service/JniCatalog.java:

http://gerrit.cloudera.org:8080/#/c/13346/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java@309
PS4, Line 309: // When there is no user having user name as user.getName() in 
the
             :       // underlying OS, the method isAdmin() in 
SentryPolicyServiceClient.class
             :       // would throw a SentryUserException. In this case, we 
also consider this
             :       // requesting user a non Sentry administrator.
reword: When a user is not defined in Sentry, isAdmin() will throw 
SentryUserException, we will consider this requesting user as a non-Sentry 
administrator.



--
To view, visit http://gerrit.cloudera.org:8080/13346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82
Gerrit-Change-Number: 13346
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fredy Wijaya <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 16 May 2019 14:07:08 +0000
Gerrit-HasComments: Yes

Reply via email to