Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13337 )
Change subject: IMPALA-8545: Test Ldap authentication ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/13337/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13337/2//COMMIT_MSG@8 PS2, Line 8: > Can you mention that this changes JdbcTests to start custom clusters. Done http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/JdbcTestBase.java File fe/src/test/java/org/apache/impala/service/JdbcTestBase.java: http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/JdbcTestBase.java@44 PS2, Line 44: // Test-local list of test tables. These are cleaned up in @After. > Brief comment? I think the important thing is that child classes should cal Done http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/JdbcTestBase.java@72 PS2, Line 72: assertNotNull("Connection is null", connection); > Brief method comment? Done http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/LdapJdbcTest.java File fe/src/test/java/org/apache/impala/service/LdapJdbcTest.java: http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/LdapJdbcTest.java@54 PS2, Line 54: > testUser_? When reading the below code I was looking for a local variable o Done http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/LdapJdbcTest.java@55 PS2, Line 55: > testPassword_? Done http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/service/LdapJdbcTest.java@73 PS2, Line 73: > I think it would be better if we changed it so either: Done http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/testutil/CustomClusterRunner.java File fe/src/test/java/org/apache/impala/testutil/CustomClusterRunner.java: http://gerrit.cloudera.org:8080/#/c/13337/2/fe/src/test/java/org/apache/impala/testutil/CustomClusterRunner.java@22 PS2, Line 22: > Can you add a note to bin/run-all-tests.sh that JdbcTests can start custom Done -- To view, visit http://gerrit.cloudera.org:8080/13337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92b5e60860c60209c1bd8afe5b3ea201fb7a7513 Gerrit-Change-Number: 13337 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 17 May 2019 20:43:35 +0000 Gerrit-HasComments: Yes
