Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 )
Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell ...................................................................... Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/12884/16/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/12884/16/be/src/service/client-request-state.h@167 PS16, Line 167: 'request_state' I assume you mean 'this request'? http://gerrit.cloudera.org:8080/#/c/12884/16/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/12884/16/common/thrift/ImpalaService.thrift@453 PS16, Line 453: operation_handle Unfortunately, our casing in this file is inconsistent, but I think you probably want this to be 'operationHandle' http://gerrit.cloudera.org:8080/#/c/12884/16/common/thrift/ImpalaService.thrift@545 PS16, Line 545: // Same as HS2 CloseOperation but can return additional information. Did you consider using the SUCCESS_WITH_INFO_STATUS/TStatus::infoMessages to accomplish the same sort of thing through the regular hs2 interface? Some reasons I can think of not to do it: - clients may not be expected it and could have code paths like "if (status != SUCCESS_STATUS) then { <assume this is an error> }' - It would require flattening the info into a string and then re-parsing on the other side. It would be nice to stick closer to vanilla hs2, though. http://gerrit.cloudera.org:8080/#/c/12884/16/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/12884/16/shell/impala_shell.py@842 PS16, Line 842: # raise ? http://gerrit.cloudera.org:8080/#/c/12884/16/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/12884/16/tests/hs2/test_hs2.py@100 PS16, Line 100: # Removed options are returned. Isn't this still testing that they're not returned? -- To view, visit http://gerrit.cloudera.org:8080/12884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d5cc83d545aacc659523f29b1d6feed672e2a12 Gerrit-Change-Number: 12884 Gerrit-PatchSet: 16 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 17:44:26 +0000 Gerrit-HasComments: Yes
