Hello Tim Armstrong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13378
to review the following change.
Change subject: IMPALA-8566. Fix computation of num_nulls for incremental stats
......................................................................
IMPALA-8566. Fix computation of num_nulls for incremental stats
The calculation for num_nulls in the incremental stats code path
initialized the counter to -1 instead of 0. This meant that, if there
were no nulls (reasonably common), the num_nulls counter would be set to
-1, indicating unknown, rather than 0.
This simply fixes the initialization and updates the tests.
Change-Id: Ie42103ad21d719cac45abc160c8d5422dd33fb28
---
M be/src/exec/incr-stats-util.cc
M
testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/truncate-table.test
3 files changed, 77 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/13378/1
--
To view, visit http://gerrit.cloudera.org:8080/13378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie42103ad21d719cac45abc160c8d5422dd33fb28
Gerrit-Change-Number: 13378
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
