Hello Lars Volker,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13391
to review the following change.
Change subject: Fix bin/set-classpath.sh error handling when sourced
......................................................................
Fix bin/set-classpath.sh error handling when sourced
559f19a5be95d686a71e616517ad4ae916c85824 added an error path to
bin/set-classpath.sh which invoked 'exit'. Since this script is meant to
be sourced, rather than executed, this exit would cause the user's shell
to exit rather than just exiting the script.
This replaces the 'exit' with 'return', which has the desired behavior.
Additionally, it adds a check to make sure that it is being invoked in
the preferred manner.
Change-Id: Ic8129444df3e6907a64c40409ebc5197dca47801
---
M bin/set-classpath.sh
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/13391/1
--
To view, visit http://gerrit.cloudera.org:8080/13391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8129444df3e6907a64c40409ebc5197dca47801
Gerrit-Change-Number: 13391
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
