Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13311 )
Change subject: IMPALA-8435. Prohibit operations on transactional table. ...................................................................... IMPALA-8435. Prohibit operations on transactional table. Copied some code from Hive to identify if the table is transactional, insert only table. Also modified code to prohibit write operations on insert only table. That code will be reverted once we add support for write operations on insert only table. Testing Done: - Added a new test in AnalyzerTest Change-Id: I740dc4ce0dbbc0c2e042b01832e606cc1ac4132a Reviewed-on: http://gerrit.cloudera.org:8080/13311 Tested-by: Todd Lipcon <t...@apache.org> Reviewed-by: Sudhanshu Arora <sudhan...@cloudera.com> Reviewed-by: Todd Lipcon <t...@apache.org> --- M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/BaseTableRef.java M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java M fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M fe/src/main/java/org/apache/impala/analysis/TruncateStmt.java A fe/src/main/java/org/apache/impala/util/AcidUtils.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java M testdata/bin/generate-schema-statements.py M testdata/datasets/README M testdata/datasets/functional/functional_schema_template.sql M testdata/datasets/functional/schema_constraints.csv 16 files changed, 296 insertions(+), 15 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified Sudhanshu Arora: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/13311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I740dc4ce0dbbc0c2e042b01832e606cc1ac4132a Gerrit-Change-Number: 13311 Gerrit-PatchSet: 15 Gerrit-Owner: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
