Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13398 )
Change subject: Add decimal_parquet to TableFormatInfo.KNOWN_FILE_FORMATS ...................................................................... Patch Set 2: Code-Review+1 This isn't referenced outside of the file - it's purely used for input validation. The actual data sets and workloads are driven by testdata/workloads/ and testdata/datasets We could consider just removing the validation if we're OK with it failing later on when it can't find the data set definition and/or database and/or tables. But this seems fine to unblock. Another possible solution would be to skip the validation when TableFormatInfo is created from tests/performance/workload_runner.py -- To view, visit http://gerrit.cloudera.org:8080/13398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9fc9c0ec82318e740a06493c1b4e4719c7162db Gerrit-Change-Number: 13398 Gerrit-PatchSet: 2 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 22 May 2019 22:38:26 +0000 Gerrit-HasComments: No
