Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 )
Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). ...................................................................... Patch Set 10: (1 comment) Patch set 11 uses the agreed approach. http://gerrit.cloudera.org:8080/#/c/12672/10/be/src/rpc/rpc-mgr-test.h File be/src/rpc/rpc-mgr-test.h: http://gerrit.cloudera.org:8080/#/c/12672/10/be/src/rpc/rpc-mgr-test.h@322 PS10, Line 322: kudu::rpc::ResponseCallback callback = []() {}; : kudu::rpc::ErrorStatusPB* error_status_pb = new kudu::rpc::ErrorStatusPB(); : error_status_pb->set_code(kudu::rpc::ErrorStatusPB::ERROR_SERVER_TOO_BUSY); : kudu::rpc::OutboundCall* outbound_call = new kudu::rpc::OutboundCall( : *conn_id_, *remote_method_, resp, controller, callback); : outbound_call->status_ = kudu::Status::RemoteError("Remote error"); : outbound_call->state_ = kudu::rpc::OutboundCall::FINISHED_ERROR; : outbound_call->error_pb_.reset(error_status_pb); : controller->call_.reset(outbound_call); > As discussed offline last week, we may be better off using a debug action i Done -- To view, visit http://gerrit.cloudera.org:8080/12672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693151c35e02235665b3c285a48c585973d390 Gerrit-Change-Number: 12672 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2019 18:38:14 +0000 Gerrit-HasComments: Yes
