Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13207 )
Change subject: IMPALA-8460: Simplify cluster membership management ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/13207/11/be/src/scheduling/executor-group-test.cc File be/src/scheduling/executor-group-test.cc: http://gerrit.cloudera.org:8080/#/c/13207/11/be/src/scheduling/executor-group-test.cc@61 PS11, Line 61: executor_group.RemoveExecutor(MakeBackendDescriptor(2)); > I'm not sure I understand the question. In this particular case it won't be Crashes of the test binary will cause a test failure. It's actually a pretty common failure mode for our tests because failed assertions cause some teardown logic to be skipped and DCHECKs get tripped as a result of resource leaks, etc. -- To view, visit http://gerrit.cloudera.org:8080/13207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3cf9a8bb060d0c6e9ec8868b7b21ce01f8740a3 Gerrit-Change-Number: 13207 Gerrit-PatchSet: 11 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2019 21:41:57 +0000 Gerrit-HasComments: Yes
