Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12940 )
Change subject: IMPALA-7322: Add storage wait time to profile ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/12940/6/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12940/6/tests/query_test/test_observability.py@567 PS6, Line 567: def test_query_profile_storage_load_time(self): > The skips are all related to hbase. It is the same as other hbase related t If you include the annotation @SkipIfS3 or @SkipIfABFS then it won't run during our automated Impala-S3 / Impala-ABFS tests. The ".hbase" suffix just displays the reason why it was disabled. I think this test needs to be split up so that we separate the HBase / Kudu specific portion of this test from the HDFS portion. It's a bit confusing, but HDFS specific tests are capable of running against S3 / ADLS, because instead of storing the data on HDFS, it is stored on S3 or ADLS. Whereas for HBase / Kudu, there is no equivalent of running a HBase / Kudu specific test against S3. The reason is that HDFS provides a FileSystem interface that allows clients to interact with any storage system, notably S3 and ADLS. Whereas clients of HBase / Kudu don't use the FileSystem interface. -- To view, visit http://gerrit.cloudera.org:8080/12940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dde7e394b7c1c396d835ef6aa0a55930c0a8660 Gerrit-Change-Number: 12940 Gerrit-PatchSet: 7 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 24 May 2019 17:23:23 +0000 Gerrit-HasComments: Yes
