Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13432 )
Change subject: WIP: IMPALA-8586: Support download URLs for CDP ...................................................................... Patch Set 1: (1 comment) The refactoring is welcome. I think the approach seems overall sane. I haven't thought about the details too much but the basic idea of an object encapsulating the package to download makes sense. http://gerrit.cloudera.org:8080/#/c/13432/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13432/1/bin/bootstrap_toolchain.py@107 PS1, Line 107: def wget_and_unpack_package(download_path, file_name, destination, wget_no_clobber): I had started working on a different change that moved a lot of this functionality to a separate python file so it could be used while bootstrapping the python virtualenv. That got stalled but it would be helpful to move it to a reusable library if you're doing a major refactoring. http://gerrit.cloudera.org:8080/13464 -- To view, visit http://gerrit.cloudera.org:8080/13432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67824fd82b820e68e9f5c87939ec94ca6abadb8c Gerrit-Change-Number: 13432 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 30 May 2019 05:32:52 +0000 Gerrit-HasComments: Yes
