Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 )
Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/13375/4/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/13375/4/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@172 PS4, Line 172: org.apache.hadoop.hive.metastore.api.Table msTbl, : boolean isHMSIntegrationEnabled these can fit on the same line http://gerrit.cloudera.org:8080/#/c/13375/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/13375/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1930 PS4, Line 1930: !KuduTable.isHMSIntegrationEnabledAndValidate(masterHosts, : hmsUris formatting - put everything after the '=' on the next line, indented by 4 http://gerrit.cloudera.org:8080/#/c/13375/4/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java File fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java: http://gerrit.cloudera.org:8080/#/c/13375/4/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@87 PS4, Line 87: public static final String HIVE_METASTORE_URIS_KEY = : "hive.metastore.uris"; This can fit on 1 line http://gerrit.cloudera.org:8080/#/c/13375/4/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/13375/4/tests/custom_cluster/test_kudu.py@129 PS4, Line 129: manged typo http://gerrit.cloudera.org:8080/#/c/13375/4/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/13375/4/tests/query_test/test_kudu.py@93 PS4, Line 93: @SkipIfKudu.hms_integration_enabled Why would a test like this, which is focused on scanning kudu tables, need to be skipped if hms integration is turned on? http://gerrit.cloudera.org:8080/#/c/13375/4/tests/query_test/test_kudu.py@175 PS4, Line 175: @SkipIfKudu.hms_integration_enabled I assume that for cases like these, where the table is modified outside of Impala, we expect that Impala will automatically pick up the changes and the error won't occur? -- To view, visit http://gerrit.cloudera.org:8080/13375 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icffe412395f47f5e07d97bad457020770cfa7502 Gerrit-Change-Number: 13375 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 31 May 2019 23:38:25 +0000 Gerrit-HasComments: Yes
