Thomas Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13400 )

Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS 
integration
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13400/4/tests/custom_cluster/test_kudu.py
File tests/custom_cluster/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/13400/4/tests/custom_cluster/test_kudu.py@117
PS4, Line 117: class TestKuduHMSIntegration(CustomClusterTestSuite, 
KuduTestSuite):
Could you add a TODO here references the JIRA you filed and mentioning that a 
lot of these tests are close copies of tests from query_test/test_kudu.py



--
To view, visit http://gerrit.cloudera.org:8080/13400
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d3b93957cc66009ad7a67fc513be2068f156abc
Gerrit-Change-Number: 13400
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Jun 2019 23:02:31 +0000
Gerrit-HasComments: Yes

Reply via email to