Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13369 )
Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges ...................................................................... IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges As shown in IMPALA-8561, there are some paths in the code which create uncacheable ScanRanges. These uncacheable ScanRanges have mtime of -1. 'mtime' is used for differentiating versions of files with the same names. An mtime == -1 means the cache entry could potentially be from any versions of a file with the same name. This change skips lookup or insertion of ScanRange with negative mtime, file offset or buffer length. Testing done: Added targeted test cases in data-cache-test Change-Id: I2294833b075a2ddcae956d9fdb04f3e85adb0391 Reviewed-on: http://gerrit.cloudera.org:8080/13369 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/io/data-cache-test.cc M be/src/runtime/io/data-cache.cc M be/src/runtime/io/data-cache.h M be/src/runtime/io/request-ranges.h 4 files changed, 47 insertions(+), 11 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2294833b075a2ddcae956d9fdb04f3e85adb0391 Gerrit-Change-Number: 13369 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
