Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 )
Change subject: IMPALA-8551: Bump CDP_BUILD_NUMBER to 1153860 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13525/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/13525/2/tests/authorization/test_ranger.py@578 PS2, Line 578: > We can but we have to parse the error message and that can be somewhat erro hrm. I agree that parsing the error message isn't super robust, but I think we could at least do something like a simple regex substitution to remove ^HTTP \d+ Error: .+' and replace it with something like "Ranger error: ... (HTTP code 403)" so that it's clear that the error came from ranger and not produced within Impala or within the user's connection. I'm concerned that if a user using Hue sees an error pop up like this they may think there's something wrong with their HTTP connection to Hue, for example. -- To view, visit http://gerrit.cloudera.org:8080/13525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8995f5dc88b211cd3af415713802cfeac44fe576 Gerrit-Change-Number: 13525 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 07 Jun 2019 17:13:07 +0000 Gerrit-HasComments: Yes
