Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13437 )
Change subject: IMPALA-5031: signed overflow is undefined behavior ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13437/1/be/src/util/arithmetic-util.h File be/src/util/arithmetic-util.h: http://gerrit.cloudera.org:8080/#/c/13437/1/be/src/util/arithmetic-util.h@117 PS1, Line 117: // This operator makes that behavior defined by doing it in the unsigned domain. > Maybe document exactly what this implies - my understand is that negating t Done -- To view, visit http://gerrit.cloudera.org:8080/13437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73dd6802ec1023275d09a99a2950f3558313fc8e Gerrit-Change-Number: 13437 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sun, 09 Jun 2019 15:53:35 +0000 Gerrit-HasComments: Yes