Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13569 )
Change subject: IMPALA-8642: krpc should depend on thrift-deps in CMake ...................................................................... Patch Set 1: We don't have that (it would be painfully slow to do from scratch). You could do a once-off test by hacking impala-config.sh or similar. The natural place to put it would be at the end of bin/jenkins/build-all-flag-combinations.sh, since at least then ccache would be warmed up. It would still be pretty slow and I'm not sure it's worth slowing down precommit. My inclination would be to not add it at this point, and only add it later if it turns out to be a recurring issue. -- To view, visit http://gerrit.cloudera.org:8080/13569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieaf9d992340f07fdf88b35fb967553fa2e35b628 Gerrit-Change-Number: 13569 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2019 15:06:12 +0000 Gerrit-HasComments: No
