Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13522 )
Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1) ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13522/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13522/4//COMMIT_MSG@28 PS4, Line 28: - Passed core tests > Did you do any testing on S3 or other object stores? Not sure what the mtim I'm running S3 tests. Nothing failing so far, so I think the DCHECKs are ok on S3. I think the big question is whether the DCHECK in ScanRange::Reset() is overly restrictive for anything like ADLS or ABFS. http://gerrit.cloudera.org:8080/#/c/13522/4/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/13522/4/be/src/exec/hdfs-scan-node-base.h@278 PS4, Line 278: /// Old API for compatibility with text scanners (e.g. LZO text scanner). > Maybe we can remove this one now? Since I think the version of the LZO scan hdfs-lzo-text-scanner.cc still uses this one. It doesn't use BufferOpts right now. BufferOpts is now mainly for try_cache, so it seems like LZO could use one of the new ones if it used BufferOpts. -- To view, visit http://gerrit.cloudera.org:8080/13522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48b7ed60d6ab9104b993237b4fe23de5dc058672 Gerrit-Change-Number: 13522 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 10 Jun 2019 21:15:23 +0000 Gerrit-HasComments: Yes
