Vihang Karajgaonkar has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13548 )
Change subject: IMPALA-8633 : Insert event should not error when table does not exists ...................................................................... IMPALA-8633 : Insert event should not error when table does not exists When a insert event is received by the events processor it is possible that the table has already been removed from metastore. In such cases, the reloadTable method throws a NoSuchObjectException which is unhandled. This causes EventProcessor to go in NEEDS_INVALIDATE state. The patch adds exception handling for such cases so that the error can be ignored and a warning is logged. Ideally, if the table has been removed from metastore, this insert event should be followed by a drop-table event and hence the table is cleaned up from the catalog subsequently. Hence Event processor does not need to remove the table from the catalog. Also, the patch adds the exception trace to the error messages during processing of Insert events to improve debugging ability in case of such errors. Testing: Refactored the existing test for insert events into util methods which can be reused for other tests. Added a new test case which generates a insert event on a table which has been dropped. This test reproduces the scenario seen by debugging test failures in IMPALA-8567. The newly added test succeeds after the patch. Change-Id: I961cd7cbede4c248dba538c7fabb4bc708e49693 --- M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java 5 files changed, 185 insertions(+), 153 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/13548/6 -- To view, visit http://gerrit.cloudera.org:8080/13548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I961cd7cbede4c248dba538c7fabb4bc708e49693 Gerrit-Change-Number: 13548 Gerrit-PatchSet: 6 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
