Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12884 )
Change subject: IMPALA-7290: part 2: Add HS2 support to Impala shell ...................................................................... Patch Set 19: Rebased. Had to make some changes for IMPALA-8605. Rebasing onto IMPALA-1653 (don't close sessions when connection closed) was more interesting - it turns out the shell was really bad about closing connections, so I had to rework the ImpalaShell lifecycle to make sure it reliably closes connections before exiting the process. Added some checks to tests. -- To view, visit http://gerrit.cloudera.org:8080/12884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d5cc83d545aacc659523f29b1d6feed672e2a12 Gerrit-Change-Number: 12884 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2019 00:08:58 +0000 Gerrit-HasComments: No
