Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13620
to review the following change.
Change subject: IMPALA-3675: part 1: -Werror for ASAN
......................................................................
IMPALA-3675: part 1: -Werror for ASAN
This fixes some clang warnings and enables -Werror going forward for
ASAN.
It adds -Wno-return-type-c-linkage to suppress a warning that otherwise
would fail the build.
It also enables the mismatched tags check and fixes the various
instances of it (this warning is irritating for YouCompleteMe users).
Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec
Reviewed-on: http://gerrit.cloudera.org:8080/11002
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/exec/hdfs-table-writer.h
M be/src/exprs/expr.h
M be/src/exprs/scalar-expr.h
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/mem-tracker.h
7 files changed, 10 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/13620/1
--
To view, visit http://gerrit.cloudera.org:8080/13620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec
Gerrit-Change-Number: 13620
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
