Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13630 )
Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java: http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@146 PS1, Line 146: kuduTable.getTabletsLocations(BackendConfig.INSTANCE.getKuduClientTimeoutMs()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@196 PS1, Line 196: " bool_col BOOLEAN NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@197 PS1, Line 197: " tinyint_col TINYINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@198 PS1, Line 198: " smallint_col SMALLINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@200 PS1, Line 200: " bigint_col BIGINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@201 PS1, Line 201: " float_col FLOAT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@202 PS1, Line 202: " double_col DOUBLE NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@203 PS1, Line 203: " date_string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@204 PS1, Line 204: " string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@205 PS1, Line 205: " timestamp_col TIMESTAMP NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd Gerrit-Change-Number: 13630 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 08:55:25 +0000 Gerrit-HasComments: Yes
