Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 )
Change subject: fe: improve logging for metadata loading ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@515 PS1, Line 515: needed to fetch partition stats > Can we create constants for these reasons. Seems they never change. Given they're only used in one place, and not 'magic numbers' that benefit from a descriptive variable name, not sure what the benefit is. Doesn't it just add another line of code and cause you to have to navigate around when reading the code? http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1954 PS1, Line 1954: why > Nit, I think have nouns as the arguments are more readable. eg: reload(Tabl will do http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@103 PS1, Line 103: hiveexec > Is there a particular reason to use the shaded version of Joiner? mistake -- eclipse loves to auto-import shaded crap :( http://gerrit.cloudera.org:8080/#/c/13463/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@628 PS1, Line 628: new Exception() > This will potentially add a lot of traces in the log. Don't we generally lo yea, this was some debugging junk I left in by mistake -- To view, visit http://gerrit.cloudera.org:8080/13463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d90a5f075b05d2dc96692b3349abe35ce24b8b8 Gerrit-Change-Number: 13463 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Jun 2019 20:10:04 +0000 Gerrit-HasComments: Yes
